-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MetalLB again #421
Merged
Merged
Bump MetalLB again #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oribon
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Bumping after removing the addresspool leftovers and adding connectTime Signed-off-by: Federico Paolinelli <[email protected]>
fedepaol
force-pushed
the
addresspoolleftovers
branch
from
February 7, 2024 13:09
fee774d
to
053ed25
Compare
Signed-off-by: Federico Paolinelli <[email protected]>
Bumping the ci's ubuntu version to something more modern (aligned with MetalLB). This is needed in particular to get a later python version, as MetalLB's latest tasks.py fails: cannot import name 'cache' from 'functools' on versions lower than 3.9. Signed-off-by: Ori Braunshtein <[email protected]>
oribon
force-pushed
the
addresspoolleftovers
branch
from
February 11, 2024 07:53
22f2a0a
to
447b6e7
Compare
This also removes some addresspools references and renames references for webhook-service to metallb-webhook-service. Signed-off-by: Ori Braunshtein <[email protected]>
oribon
force-pushed
the
addresspoolleftovers
branch
from
February 11, 2024 07:55
447b6e7
to
80130da
Compare
Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Signed-off-by: Ori Braunshtein <[email protected]>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping after removing the addresspool leftovers